Conversation
Testing GuidelinesHi @mikejolley , Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
📝 WalkthroughWalkthroughPatch update: textarea styles for checkout changed so placeholders inherit global text color on light themes (using currentColor); typed text and focus visuals adjusted via :not(:placeholder-shown) and explicit input-text tokens. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: +83 B (0%) Total Size: 5.98 MB |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
mikejolley
left a comment
There was a problem hiding this comment.
Its a bit confusing how sometimes placeholders/labels use theme color, and sometimes not light vs dark but thats not within the scope of this PR. For this one, yes, I confirmed the placeholder matches other inputs so LGTM 👍🏻
Yes I believe the long-term plan is to normalise all these forms so they can be controlled directly by global styles, for now trying to fix the discrepancy is not recommended as we don't know what impact this will have on existing stores. Thanks Mike. |
…63539) * Make textareas show placeholder text the same as regular inputs * Add changelog * Remove opacity and show placeholder at full opacity * Update CSS to preserve placeholder colour on focus
…63539) * Make textareas show placeholder text the same as regular inputs * Add changelog * Remove opacity and show placeholder at full opacity * Update CSS to preserve placeholder colour on focus
Changes proposed in this Pull Request:
Checkout textarea placeholder text does not inherit the global text color from WordPress theme styles. Regular input placeholders were updated in PR #46362 to pull in global styles, but textarea placeholders were missed.
The textarea component hardcoded its
colorto$input-text-light, preventing::placeholderfrom inheriting the theme's text color. This fix changes the textarea to usecolor: inheritso the placeholder picks up the global color, then resets typed text back to$input-text-lightvia:not(:placeholder-shown).Closes WOOPRD-1577
Screenshots or screen recordings:
How to test the changes in this Pull Request:
#2b2d2f), matching other input fields.Testing that has already taken place:
Milestone
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment