[Enhancement]: Block-based checkout input fields style updates#46362
[Enhancement]: Block-based checkout input fields style updates#46362nielslange merged 27 commits intotrunkfrom
Conversation
…t-input-fields-style
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Yeah. That's great to hear! 🎉
Thanks for pointing this out. I've adjusted this earlier.
This one might be a bit tricky to address, given that the Stripe input fields are within an iframe.
That's a good call. I'll update the testing instructions accordingly. |
alexflorisca
left a comment
There was a problem hiding this comment.
Thanks for the updates Niels, good shout about using the currentColor for focused elements! Good to go!
|
Thanks for reviewing and approving this PR, @alexflorisca! 🙌 |
* Adjust border and box-shadow color for textual inputs * WIP: Style checkboxes * Vertically center checkmark * Adjust focus outline width * Adjust selected checkbox background in light mode * Adjust background color of selected radio button * Add chevron icon to dropdown fields * Add changelog * Fix CSS lint issues * Adjust outline width * Revert checkbox styles * Adjust input field height and label size * Revert box-shadow styles * Add spacing between coupon title and coupon code * Simplify onFocus and onBlur * Fix outline width when focusing combobox * Ensure chevron points down after selecting value * Adjust outline color of focused delivery option * POC: Use currentColor for focus states
* Revert #46362 (#49404) * Revert #46262 * Remove pnpm-lock.yaml * Revert "Remove pnpm-lock.yaml" This reverts commit df4b879. * Add changefile(s) from automation for the following project(s): woocommerce-blocks * Revert pnpm-lock.yaml --------- Co-authored-by: github-actions <github-actions@github.com> * Prep for cherry pick 49404 --------- Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com>
* Adjust border and box-shadow color for textual inputs * WIP: Style checkboxes * Vertically center checkmark * Adjust focus outline width * Adjust selected checkbox background in light mode * Adjust background color of selected radio button * Add chevron icon to dropdown fields * Add changelog * Fix CSS lint issues * Adjust outline width * Revert checkbox styles * Adjust input field height and label size * Revert box-shadow styles * Add spacing between coupon title and coupon code * Simplify onFocus and onBlur * Fix outline width when focusing combobox * Ensure chevron points down after selecting value * Adjust outline color of focused delivery option * POC: Use currentColor for focus states
Changes proposed in this Pull Request:
Closes #46008.
This PR introduces the following changes:
Border and outline color adjustments:
$universal-border-lightas the outline/border color with a width of 1px when not focused.$input-border-grayfor the outline/border/box-shadow color with a width of 2px when focused.Field height and label text size adjustments:
Dropdown chevron icon behavior:
Inherit global colors:
Spacing adjustments for coupon code:
.wc-block-components-totals-discount__coupon-list.Testing Instructions:
The testing instructions provided guide the tester through verifying each of these changes in detail, ensuring that the changes work as intended and that the UI behaves consistently when interacting with the updated elements.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions
Before all test cases
/wp-admin/edit.php?post_type=shop_couponand create a test coupon.Outline colors
Note
In this context, "outline" is used generically, though some elements may require adjustments to
borderorbox-shadowproperties. The term "outline" should be understood to impact all relevant elements uniformly. Follow these steps for verification:$universal-border-lightas the outline/border color and that the outline/border width is 1px.$input-border-grayfor outline/border/box-shadow color, and that the outline/border/box-shadow width is 2px.Field height and label text size
Dropdown chevron icon
Inherit global colors
Apperance » Editor » Pages » Checkout.Browse styles.Rust:#5E81AC.Spacing between coupon title and coupon code
Note
The following fix was not part of the initial issue. However, due to its small scope, we decided to include it in this PR. This decision was agreed upon in this Slack discussion.
.wc-block-components-totals-discount__coupon-listhas a top margin of 4px.Changelog entry
Details
Significance
Type
Message
Comment