plugins/woocommerce/client/admin/client/task-lists/fills/shipping/index.js (2)

213-217: DRY: reuse hasInstallableSlug here instead of duplicating its logic.

The filter predicate duplicates the check that hasInstallableSlug already encapsulates. Since you're mapping to just the slug string first, a small restructure would keep this DRY.

♻️ Suggested refactor

-		const pluginsToActivate = pluginsToPromote
-			.map( ( pluginToPromote ) => pluginToPromote.slug )
-			.filter(
-				( slug ) => typeof slug === 'string' && slug.trim().length > 0
-			);
+		const pluginsToActivate = pluginsToPromote
+			.filter( hasInstallableSlug )
+			.map( ( pluginToPromote ) => pluginToPromote.slug );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/client/admin/client/task-lists/fills/shipping/index.js`
around lines 213 - 217, The current map-then-filter duplicates logic; instead
use hasInstallableSlug to DRY this. Change the pipeline so you first filter
pluginsToPromote with hasInstallableSlug and then map to plugin.slug (i.e.,
pluginsToActivate = pluginsToPromote.filter(hasInstallableSlug).map(p =>
p.slug)); reference hasInstallableSlug, pluginsToPromote and pluginsToActivate
to locate and replace the existing map(...).filter(...) sequence.

---

381-381: visible is a number here; other steps use explicit booleans.

pluginsToPromote.length evaluates to a number (truthy when > 0), while other visible fields use true/false. Functionally fine, but pluginsToPromote.length > 0 would be more consistent.

♻️ Suggested fix

-				visible: pluginsToPromote.length,
+				visible: pluginsToPromote.length > 0,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/woocommerce/client/admin/client/task-lists/fills/shipping/index.js`
at line 381, The visible property is set to a number via
pluginsToPromote.length; change it to an explicit boolean for consistency by
using pluginsToPromote.length > 0 (i.e., replace visible:
pluginsToPromote.length with visible: pluginsToPromote.length > 0), locating the
assignment to visible near the pluginsToPromote variable in the
shipping/index.js fill step.

plugins/woocommerce/client/admin/client/task-lists/fills/shipping/test/index.tsx (1)

89-99: Good coverage of the core cases. Consider adding a whitespace-only slug test (slug: ' ') since hasInstallableSlug explicitly trims — this would exercise that branch.

🧪 Optional additional test

 	it( 'treats missing slugs as non-installable partners', () => {
 		expect( hasInstallableSlug( {} ) ).toBe( false );
 	} );
+
+	it( 'treats whitespace-only slugs as non-installable partners', () => {
+		expect( hasInstallableSlug( { slug: '   ' } ) ).toBe( false );
+	} );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@plugins/woocommerce/client/admin/client/task-lists/fills/shipping/test/index.tsx`
around lines 89 - 99, Add a test case exercising the trim branch of
hasInstallableSlug by asserting that a partner object with a whitespace-only
slug (e.g., { slug: '   ' }) is treated as non-installable; locate the test
block in the file that contains the existing cases for
usShippingPartner/chileShippingPartner/missing slug and add a new it() asserting
hasInstallableSlug({ slug: '   ' }) returns false so the trimming logic is
covered.