Make $fallback_to_production attribute work as expected#242
Merged
slimndap merged 1 commit intoslimndap:masterfrom Jun 11, 2017
joostdekeijzer:wpt_event-custom-fallback_to_production
Merged
Make $fallback_to_production attribute work as expected#242slimndap merged 1 commit intoslimndap:masterfrom joostdekeijzer:wpt_event-custom-fallback_to_production
$fallback_to_production attribute work as expected#242slimndap merged 1 commit intoslimndap:masterfrom
joostdekeijzer:wpt_event-custom-fallback_to_production
Conversation
slimndap
added a commit
that referenced
this pull request
Jun 11, 2017
…stom_html(). Added tests to confirm #242.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$fallback_to_productionargument currently doesn't do anythingThis PR makes the argument work.
The rewrite is needed to have both
WPT_Event::custom( 'field', [], true )andWPT_Event::custom( 'field', [], false )work as expected.