Dataviews: All Templates: Add filters to template author.#56338
Merged
jorgefilipecosta merged 1 commit intotrunkfrom Nov 28, 2023
Merged
Dataviews: All Templates: Add filters to template author.#56338jorgefilipecosta merged 1 commit intotrunkfrom
jorgefilipecosta merged 1 commit intotrunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
|
Size Change: +101 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
23e13bf to
5289030
Compare
Member
Author
|
Hi @ntsekouras, now that sorting is merged I guess this one is ready for review. |
ntsekouras
reviewed
Nov 28, 2023
ntsekouras
reviewed
Nov 28, 2023
| if ( | ||
| filter.field === 'author' && | ||
| filter.operator === OPERATOR_IN && | ||
| filter.value !== '' |
Contributor
There was a problem hiding this comment.
Do we need to check explicitly for empty string?
Member
Author
There was a problem hiding this comment.
I updated the condition to check if the filter has value instead of checking for an empty string.
oandregal
reviewed
Nov 28, 2023
| per_page: -1, | ||
| } ); | ||
|
|
||
| const allAuthorElements = useMemo( () => { |
Member
There was a problem hiding this comment.
This could be named just authors, I guess?
Member
Author
There was a problem hiding this comment.
Suggestion applied 👍
060846e to
87a688d
Compare
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the follow-ups on #55848 (comment).
Adds an author filter to all templates view.
Screenshot
Testing
Go to the manage all templates page.
Verify it is possible to filter templates by author.