Size Change: +5 B (0%)

Total Size: 1.7 MB

_{compressed-size-action}

Side note: While working on this, I noticed that when you reset the image from MediaReplaceFlow, the tools panel still shows the reset option.

I can reproduce it on the trunk, so it's probably a different issue with the tools panel. Will investigate separately.

Screencast

@Mamaduka can we tag this as a fix for 6.4.1?

@richtabor, it should be okay, as this fixed a missed bug in WP 6.4.

cc @mikachan

Thanks for the quick fix! 🙇

Side note: While working on this, I noticed that when you reset the image from MediaReplaceFlow, the tools panel still shows the reset option.
I can reproduce it on the trunk, so it's probably a different issue with the tools panel. Will investigate separately.

The ToolsPanel always shows a Reset all button, but it's disabled when there's no value. This seems to be consistent across each of the different kinds of panels. I think I'd probably lean toward keeping the Reset all button there for the ToolsPanels (though disabled) so that there's less jumpiness in that part of the UI. But we can look at that separately if need be, as you mention!

Update: @Mamaduka and @richtabor I just gave this a test on trunk, and I think I remember why we left the Reset button there rather than removing it when there's no value. Unfortunately, when we remove the button altogether we break keyboard accessibility as it results in a focus loss when Reset is selected:

I wonder if we can explicitly set focus to the MediaReplaceFlow component (or to the Upload button) when we reset the background image, so that we don't lose focus altogether?

Update to the update: I have a fix for the focus loss issue up over in #55984 — the idea there is to shift focus and simulate a click on the toggle button to close the dropdown and move focus to the toggle button when the background image is reset. I think that should hopefully get us back to the desired keyboard accessibility while preserving this fix! 🤞

I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: b1b4034