Merged
Conversation
Mamaduka
commented
Aug 9, 2023
| select( interfaceStore ).getActiveComplementaryArea( scope ) === | ||
| identifier, | ||
| [ identifier ] | ||
| [ identifier, scope ] |
Member
Author
There was a problem hiding this comment.
The selector should rerun when the scope (string) changes.
Mamaduka
commented
Aug 9, 2023
Comment on lines
+88
to
+89
| disableComplementaryArea, | ||
| enableComplementaryArea, |
Member
Author
There was a problem hiding this comment.
The disableComplementaryArea and enableComplementaryArea have stable references.
Mamaduka
commented
Aug 9, 2023
Comment on lines
+162
to
+163
| enableComplementaryArea, | ||
| disableComplementaryArea, |
Mamaduka
commented
Aug 9, 2023
| ( select ) => | ||
| select( interfaceStore ).isFeatureActive( scope, feature ), | ||
| [ feature ] | ||
| [ feature, scope ] |
Member
Author
There was a problem hiding this comment.
The selector should rerun when the scope (string) changes.
|
Size Change: +23 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 9, 2023
Member
tyxla
left a comment
There was a problem hiding this comment.
Changes are straightforward and make sense to me. Thanks 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR fixes ESlint warnings in the
interfacepackage.Why?
I'm working on a different PR to replace
withPluginContextHoC usage in the package with theusePluginContexthook and decided to extract these code quality changes.Testing Instructions
CI checks should be green.