[5.4] Fix TinyMCE init to work in Firefox Developer edition#46889
[5.4] Fix TinyMCE init to work in Firefox Developer edition#46889richard67 merged 3 commits intojoomla:5.4-devfrom
Conversation
|
@korenevskiy @OctavianC @muhme As you had tested the other PR #46852 , could you also test this one here? |
|
Great, everything is working. |
@korenevskiy Thank you for testing 👍 Could you please also test with multiple browsers and count the test result in our issue tracker? |
|
I have tested this item ✅ successfully on db71366
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46889. |
|
👍 Microsoft Edge 144.0.3719.115 (64x) Windows 11 Pro |
I don't have access to this page, so there may be a regional Internet lockdown. |
|
I have tested this item ✅ successfully on db71366
Mac:
The Mac I've tested this with is an older Mac Mini with an Intel i5 so any looping code is more obvious - after dragging an Editor Field it takes a few seconds for the content to appear (the editor is loaded but it's blank). Can live with that as my initial problem was article editing being unresponsive (and any editor present on the page would eat up the memory due to the constant reinitialization). While extensively testing #46852 (to compare it against this PR) I ran across a bug where if I drag and drop the Fields a few times I get an unresponsive editor (the one that was dragged) on Firefox - so far, this PR seems to work better. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46889. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46889. |
|
Thanks @Fedik for this PR, and @muhme , @korenevskiy and @OctavianC for testing. |
Visit: "System" => "Clear Cache" and delete "_media_version" or just use Delete All |
|
Thanks @richard67 @HermanPeeren @Fedik |
|
Is possible make a hotfix for v4? |
Yes, we’re working on a hotfix that will address this in 5.4.3 and 6.0.3. |
@muhme He was asking for Joomla 4, i.e. 4.4.14. |
|
Just to let you know, I just changed the tinymce files according for 4.4.14, using the same code as this PR, and is working so far. |
|
open the address of the modified JS file in a new tab in the browser. Check if the file is fixed or not. It will be clear how to achieve a cache update on the server. |
|
The patch has a sligthly php error, double comments open. |
Should be irrelevant for the hotfix
what you mean with this? |
Hi everyone, |
Update to 5.4 or 6.0. 4.4 is unsupported since half a year. |
or switch browser |
|
or use a version of firefox as old and unsupported as your version of joomla |
I am aware of this and the update will happen eventually, but the specific website has some tailor made features that are not compatible with 5.4, so it will take some time. I was hoping to find an easy fix for the meantime, especially since @carlitorweb mentioned it worked for him, but I guess "switch browser" is the solution. |
Did you remove the .min file? Is just a hotfix until we update Joomla. I will send later the modified file I have that worked for me, maybe can be useful for you. |
The |
|
I deleted all 3 files, tinymce.js tinymce.min.js and tinymce.js.gz and replaced them with the files in the hotfix. I didn't run any skripts or so, I just deleted the old files and uploaded the new ones. I tried both versions (5.4 and 6.0) mentioned by @HLeithner and the download from @brianteeman I went to System -> Clear Cache -> and deleted _media_version Going back into an article, the editor is gone and I see html code. @carlitorweb you wanted to send me some files? I must be missing something simple. |
What you mean by "Going back into an article"? also did you cleared your browser cache, just to be sure. it's also possible that a reverse proxy caches the old js files at server side. |
|
With "going back into an article" I mean that I open an exisiting article where we have the issue with the flickering/reloading editor. I was also wondering if it is a problem with the cache, but when I replace the files, the editor disappears and when I re-install the old files, the editor including flickering is back, so I guess that I have successfully cleared the cache, haven't I ? |
|
ok, thanks can you provide a screencast and detailed version number and system of the browser please. @Fedik do you see a reason for this? |
|
Thank you for your support! My computer is a iMac M1 2021 with macOS Tahoe 26.1 |
|
ah ok joomla 4, we don't support joomla 4 any longer and it's possible that the new tinymce file is not compatible with the tnymce version is shipped in j4. I fear that will be a won't fix. But maybe someone come up with an solution. What's the reason you don't update to j5/6? edit: I overlooked the j4 comments where you already answered the questions. |
|
The direct copy from Joomla 5 to Joomla 4 will not work. Copy and replace section with joomla-cms/build/media_source/plg_editors_tinymce/js/tinymce.es6.js Lines 197 to 220 in a280811 in to |
That worked! Thank you! |
|
Did somebody test if it works also for firefox on mobile devices. For me it doesn't on two different sites on mobile, desktop is fine. I still get the reloading. |
I retested now, with 5.4.3 I am getting the reloading in Firefox 145.0.2 on Android 14. And it is fixed (no more releading) with the 5.4-dev branch, including this merged PR. |
I had the same problem, try this: |
Pull Request resolves #46738 .
Alternative to #46852
Summary of Changes
Fix TinyMCE init to work in Firefox Developer edition.
There some bug in this version of Firefox or in TinyMCE itself when iframe is in "in-completed" state after TinyMCE initialization.
Testing Instructions
Apply patch and run
npm install(or install prebuilt package).Test should be run in all browsers: Chrome, Firefox, Firefox Developer edition, and Safari would be good also.
Test 1) Open any article and try edit content.
Test 2) Create subform field with editor in it, add some content and then reorder subform rows.
Actual result BEFORE applying this Pull Request
For all tests the editor is unusable in Firefox Developer edition, infinity reload.
Other browsers works good.
Expected result AFTER applying this Pull Request
Test 1) Editor works in all browser, content is editable.
Test 2) Before and After sorting the editors works in all browser, content is editable.
Link to documentations
Please select: