Clarify that small overlay UIs are allowed in exclusive access#709
Merged
toji merged 2 commits intoimmersive-web:masterfrom Jun 17, 2019
Merged
Clarify that small overlay UIs are allowed in exclusive access#709toji merged 2 commits intoimmersive-web:masterfrom
toji merged 2 commits intoimmersive-web:masterfrom
Conversation
toji
reviewed
Jun 17, 2019
|
|
||
| NOTE: Examples of ways [=exclusive access=] may be presented include stereo content displayed on a virtual reality or augmented reality headset, or augmented reality content displayed fullscreen on a mobile device. | ||
|
|
||
| NOTE: As an example of overlaid UI, the user-agent or operating system in {{immersive-ar}} mode may overlay mandatory "home" and navigational buttons over the user's wrist. |
Member
There was a problem hiding this comment.
I support of this change, but the example given here is pretty AR-centric and only applies to a single device that I'm aware of. We don't have to remove it, but could we add a reference to something more common, like notification messages? I've seen that on a lot more platforms.
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #469
I don't really address the "immersive session left at a part of the room to be returned to" concern, I'm not sure how that can be handled or if that even should be handled by immersive-ar the same way.
r? @toji