Conversation
NellWaliczek
reviewed
Mar 7, 2019
34d97ee to
f4e292a
Compare
Member
Author
|
Updated to address Nell's comments. PTAL! |
Member
Author
|
Okay, added a requirement for |
Member
Author
|
Review ping for @NellWaliczek. Any further changes you'd like to see? I'm feeling pretty good that this is ready-to-land. |
NellWaliczek
approved these changes
Apr 4, 2019
Member
NellWaliczek
left a comment
There was a problem hiding this comment.
Thanks for your thorough work on this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-in-progress PR for gamepad integration spec text. Mostly still need to address the
gamepad.idformatting. It's far enough along though that some feedback would be useful. I'd especially like feedback on the new mapping diagram and whether it helps or hurts understanding.