ESLint: Update eslint-plugin-testing-library to v6#54910
Merged
Conversation
tyxla
commented
Sep 28, 2023
| /** | ||
| * External dependencies | ||
| */ | ||
| // eslint-disable-next-line testing-library/no-manual-cleanup |
Member
Author
There was a problem hiding this comment.
We intend to use cleanup() in afterEach() here since the default way it automatically cleans up doesn't work for this scenario.
| */ | ||
| import BaseInputControl from '../'; | ||
|
|
||
| const setupUser = () => userEvent.setup(); |
Member
Author
There was a problem hiding this comment.
I figured this wrapper was just unnecessary and directly inlined userEvent.setup().
Mamaduka
approved these changes
Sep 28, 2023
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR bumps
eslint-plugin-testing-libraryto v6.Why?
It's simply a dependency change, to keep the testing library tests up to date with the latest best practices of writing component tests.
How?
We're bumping the version and fixing a couple of ESLint errors.
Testing Instructions
Verify all checks are green.
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.