Adjust size of image previews in list view#53649
Merged
Conversation
|
Size Change: -5 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 14, 2023
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for the detailed follow-up! This is looking nice to me:
Just added Jay as a reviewer since I'm not a designer, but this LGTM! ✨
Member
|
Let's try it, if it feels optically too small we can go back to 20. |
jameskoster
approved these changes
Aug 15, 2023
Contributor
jameskoster
left a comment
There was a problem hiding this comment.
It bugs me that the value doesn't sit nicely on the 4px scale, but that's an issue with the icon.
Member
Author
Same. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #53381. Minor adjustment to list view image previews, matching the image icon size. The negative margin is set to display two-thirds of each image now as well.
Testing Instructions
Screenshots or screencast