Merged
Conversation
|
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
51928a8 to
404f50d
Compare
youknowriad
commented
Aug 10, 2023
| "packages/a11y": { | ||
| "name": "@wordpress/a11y", | ||
| "version": "3.38.0", | ||
| "version": "3.39.0", |
Contributor
Author
There was a problem hiding this comment.
I have no idea why I had to rebase and push these changes? I didn't change the versions of these packages myself.
Member
There was a problem hiding this comment.
I fixed it in 3e7cdc7. The long story short:
- npm publishing failed last week for the branch using npm 6/node 14
- I executed it manually today, and I had to manually cherry-pick changes to
package.jsonandpackage-lock.json. - It turns out that the lock files have a different format with npm 6 vs npm 8 so I didn't catch that immediately because cherry-picking went well ...
gziolo
approved these changes
Aug 10, 2023
Member
gziolo
left a comment
There was a problem hiding this comment.
I hope that unit tests correctly cover the usage of mkdirp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
While doing the node/npm migration, I've noticed a few messages when installing packages. Among them, the fact that we're using a few deprecated packages. I'm trying to clean these out a little bit.
This PR just updates the mkdirp dependency that is being used in a couple tests.
Testing instructions