Fix image stretching with only height#53443
Merged
Conversation
|
Size Change: -8 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
ajlende
commented
Aug 8, 2023
Comment on lines
+493
to
+505
| // CSS includes `height: auto`, but we need | ||
| // `width: auto` to fix the aspect ratio when | ||
| // only height is set due to the width and | ||
| // height attributes set via the server. | ||
| width: | ||
| ! newWidth && newHeight | ||
| ? 'auto' | ||
| : newWidth, |
Contributor
Author
There was a problem hiding this comment.
It was already a really long comment, but I couldn't add height: auto to the CSS either because it breaks aspect ratio when it and width: auto are both set.
I also can't really remove height: auto from the CSS and handle it all here or it'll break existing blocks.
6f51e53 to
fb5e548
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix image scaling with only height set.
Why?
Images with only a height set can become stretched because the server adds width and height attributes to all images.
How?
Add
width: autoto the image so it scales correctly.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After