Hide pattern previews on hover in inserter#53331
Merged
kevin940726 merged 1 commit intotrunkfrom Aug 8, 2023
Merged
Conversation
|
Size Change: +15 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Aug 7, 2023
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM! 👍
✅ Could replicate the original issue
✅ Applying this PR fixes the unnecessary pattern preview for unsynced patterns
✅ Synced patterns continue previewing correctly
Thanks @kevin940726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix #50495. Hide the pattern previews on hover in the inserter.
Why?
There are already previews in the inserter sidebar, so we don't need to show the popover preview again.
How?
Use
onHoverPatternfor pattern items.Testing Instructions
Follow the instructions in #50495. Or follow the instructions in the below screencast.
Testing Instructions for Keyboard
Same as above. The preview is visual only so this PR has no impact for screen reader users. The preview also only shows when the user is using a mouse to hover over the item, it doesn't show when the item is focused via the keyboard.
Screenshots or screencast
Kapture.2023-08-04.at.16.24.30.mp4