Edit Post: Replace 'withPluginContext' in the 'PluginPostPublishPanel'#53302
Merged
Edit Post: Replace 'withPluginContext' in the 'PluginPostPublishPanel'#53302
Conversation
|
Size Change: +881 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 4, 2023
Member
tyxla
left a comment
There was a problem hiding this comment.
LGTM, thanks 👍 🚀
Left a minor suggestion, but it's optional, feel free to ignore.
|
|
||
| const { Fill, Slot } = createSlotFill( 'PluginPostPublishPanel' ); | ||
|
|
||
| const PluginPostPublishPanelFill = ( { |
Member
There was a problem hiding this comment.
There was indeed no need to have this as a separate component 👍
ntsekouras
approved these changes
Aug 4, 2023
…panel/index.js Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
…panel/index.js Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
This was referenced Oct 23, 2024
This was referenced Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR replaces the use of
withPluginContextin thePluginPostPublishPanelcomponent with the newusePluginContexthook.Why?
The
useContexthook or its wrappers is recommended way to consume context in modern React.Testing Instructions
Code
Screenshots or screencast