LinkControl: prevent overflow when the title is a URL#53356
Merged
Conversation
|
Size Change: +39 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Aug 8, 2023
Contributor
getdave
left a comment
There was a problem hiding this comment.
Thank you this was a good catch 🙇♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53352
What?
This PR prevents overflow in the
LinkControlcomponent when the title is a URL.Why?
It is the title that is causing the problem, but since the
overflow-wrap: break-word;is applied, it will wrap properly for text containing normal words. However, if thehasRichPreviewsisfalse, as in the Button block LinkControl, the title displayed is the URL itself.How?
Just as
word-break: break-word;is applied to the URL that appears below the title, I think I need to apply the same style only if the title is a URL. I have used theis-url-titleclass to make the decision and apply theword-break: break-all;if the title is a URL.Testing Instructions