Skip to content

@wordpress/reusable-blocks is missing a dependency on @babel/runtime #41343

@anomiex

Description

@anomiex

The package @wordpress/reusable-blocks attempts to use @babel/runtime from build/store/index.js and a few other files, but does not declare a dependency or peer dependency on that package.

This happens to work with npm's hoisting due to other dependencies pulling that package in, but will fail with yarn's p'n'p or pnpm with hoisting disabled.

Reproduction

With yarn:

  1. Create a temporary directory, and cd into it.
  2. echo '{}' > package.json
  3. yarn set version stable
  4. yarn add @wordpress/reusable-blocks react@^17 react-dom@^17 @babel/core jsdom global-jsdom
  5. yarn node -e 'require( "global-jsdom/register" ); const x = require( "@wordpress/reusable-blocks" ); console.log( typeof x );'

With pnpm:

  1. Create a temporary directory, and cd into it.
  2. echo 'hoist-pattern=[]' > .npmrc
  3. pnpm add @wordpress/reusable-blocks react@^17 react-dom@^17 @babel/core jsdom global-jsdom
  4. node -e 'require( "global-jsdom/register" ); const x = require( "@wordpress/reusable-blocks" ); console.log( typeof x );'

Expected behavior

Output along the lines of

object

Actual behavior

With yarn:

Error: @wordpress/reusable-blocks tried to access @babel/runtime, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @babel/runtime (via "@babel/runtime/helpers/interopRequireDefault")
Required by: @wordpress/reusable-blocks@virtual:dc3fc578bfa5e06182a4d2be39ede0bc5b74940b1ffe0d70c26892ab140a4699787750fba175dc306292e80b4aa2c8c5f68c2a821e69b2c37e360c0dff36ff66#npm:3.7.0 (via /tmp/test/.yarn/__virtual__/@wordpress-reusable-blocks-virtual-e6567251b7/0/cache/@wordpress-reusable-blocks-npm-3.7.0-e679b65a35-c056fd94ea.zip/node_modules/@wordpress/reusable-blocks/build/store/)

With pnpm:

Error: Cannot find module '@babel/runtime/helpers/interopRequireDefault'
Require stack:
- /tmp/test/node_modules/.pnpm/@wordpress+reusable-blocks@3.7.0_noz7egsnsfdcs6s6px6pthieke/node_modules/@wordpress/reusable-blocks/build/store/index.js
- /tmp/test/node_modules/.pnpm/@wordpress+reusable-blocks@3.7.0_noz7egsnsfdcs6s6px6pthieke/node_modules/@wordpress/reusable-blocks/build/index.js

Metadata

Metadata

Assignees

Labels

Good First IssueAn issue that's suitable for someone looking to contribute for the first time[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intendednpm PackagesRelated to npm packages

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions