-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Improve Navigation block color controls #44712
Copy link
Copy link
Open
Labels
[Block] NavigationAffects the Navigation BlockAffects the Navigation Block[Feature] Navigation MenusAny issue relating to Navigation MenusAny issue relating to Navigation Menus[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Metadata
Metadata
Assignees
Labels
[Block] NavigationAffects the Navigation BlockAffects the Navigation Block[Feature] Navigation MenusAny issue relating to Navigation MenusAny issue relating to Navigation Menus[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Type
Fields
Give feedbackNo fields configured for issues without a type.
What problem does this address?
Currently the Navigation block implements custom controls for all aspects of color including:
However these are used in a non-standard way which causes confusion and holds the potential for bugs.
The key problems are:
color: inherit). However this is vulnerable to being overriden byLinkstyles coming from ancestor blocks using global styles.What is your proposed solution?
As the block has been around for some time, these problems are not trivial to solve. Some suggestions include:
TextandBackground.Text,BackgroundandLinkvia Block Supports. This will involve separating the Submenu and Overlay menu color controls from the other controls.