Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

fix: update footers and apply to templates#161

Closed
alaminfirdows wants to merge 19 commits intoWordPress:trunkfrom
alaminfirdows:fix/footers
Closed

fix: update footers and apply to templates#161
alaminfirdows wants to merge 19 commits intoWordPress:trunkfrom
alaminfirdows:fix/footers

Conversation

@alaminfirdows
Copy link
Copy Markdown
Contributor

@alaminfirdows alaminfirdows commented Aug 31, 2023 •
edited
Loading

Description

I noticed that the footer-writer.html and footer-portfolio.html files contain outdated content. Additionally, the home-portfolio.html and home-writer.html templates are not currently utilizing the template parts. This pull request aims to update both the footers and templates with updated content.

It also fixes the footer text (Designed with) visibility issue.

resolves #146

Screenshots
Screenshot

@huzaifaalmesbah
Copy link
Copy Markdown
Member

huzaifaalmesbah commented Aug 31, 2023

You can check #147
already discussed this issue.

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Sep 1, 2023

Please make sure that:

  • The image in the footer is the site logo block
  • The social links use the social icon block with the label setting enabled.
  • The copyright text uses the site title, not a hard-coded text.
  • All text is translation-ready

@alaminfirdows
Copy link
Copy Markdown
Contributor Author

alaminfirdows commented Sep 1, 2023

You can check #147 already discussed this issue.

@huzaifaalmesbah Thank your for the reference. I've replaced the WordPress credit section by footer.php pattern. Please check now.

@alaminfirdows
Copy link
Copy Markdown
Contributor Author

alaminfirdows commented Sep 1, 2023

@carolinan The appearance of the footer.php pattern within the footer templates doesn't match the design in Figma.

The pattern has some padding inside. Should we consider removing the padding or perhaps designing a separate pattern for the WordPress credit section?

Group 25

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Sep 1, 2023 •
edited
Loading

Yeah, try removing the spacing and the text align from the pattern, and re-add those to the template parts.

@alaminfirdows
Copy link
Copy Markdown
Contributor Author

alaminfirdows commented Sep 1, 2023

Please make sure that:

  • The image in the footer is the site logo block
  • The social links use the social icon block with the label setting enabled.
  • The copyright text uses the site title, not a hard-coded text.
  • All text is translation-ready

Currently the social icon block only support icon+label, it doesn't support the label only.

@MaggieCabrera
Copy link
Copy Markdown
Collaborator

MaggieCabrera commented Sep 12, 2023

Closing this one in favor of #318

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

[Component] Template Parts [Component] Templates [Type] Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer text "Designed with" is not visible.

5 participants

@alaminfirdows @huzaifaalmesbah @carolinan @MaggieCabrera @juanfra